Eliminate SSH key validation in deploy.yml #22

rdenadai · 2025-10-18T19:15:05Z

rdenadai commented

2025-10-18 19:15:05 +00:00

(Migrated from github.com)

Remove SSH key validation step in deploy workflow

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-18 19:15:21 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR removes SSH key validation from the deployment workflow to streamline the deployment process. The change eliminates the verification step that checked the validity of the SSH private key before attempting to connect to the remote server.

Removed SSH key validation command that would exit the workflow if the key was invalid

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR removes SSH key validation from the deployment workflow to streamline the deployment process. The change eliminates the verification step that checked the validity of the SSH private key before attempting to connect to the remote server. - Removed SSH key validation command that would exit the workflow if the key was invalid --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/rdenadai/web.redecapivara.social/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

.github/workflows/deploy.yml

					
				@ -41,4 +41,3 @@

				          ssh-keygen -l -f ~/.ssh/id_rsa || { echo "Invalid SSH key"; exit 1; }

				          ssh-keyscan -p ${{ secrets.SSH_PORT }} -H "${{ secrets.VM_IP }}" >> ~/.ssh/known_hosts 2>/dev/null || true

				      - name: Deploy dist/ to VM:/pds

Removing SSH key validation eliminates early error detection. Without this validation, deployment failures due to invalid SSH keys will only be discovered later in the process, making debugging more difficult and potentially wasting CI/CD resources.


      - name: Validate SSH private key format
        run: |
          if ! ssh-keygen -y -f ~/.ssh/id_rsa > /dev/null 2>&1; then
            echo "Error: Invalid SSH private key format"
            exit 1
          fi

Removing SSH key validation eliminates early error detection. Without this validation, deployment failures due to invalid SSH keys will only be discovered later in the process, making debugging more difficult and potentially wasting CI/CD resources. ```suggestion - name: Validate SSH private key format run: | if ! ssh-keygen -y -f ~/.ssh/id_rsa > /dev/null 2>&1; then echo "Error: Invalid SSH private key format" exit 1 fi ```