feat: This adds a huge amount of changes #21

rdenadai · 2025-10-18T19:05:42Z

rdenadai commented

2025-10-18 19:05:42 +00:00

(Migrated from github.com)

This pull request introduces several UI improvements, dependency updates, and code cleanups. The most significant changes include the addition of an emoji picker component, enhancements to the social post actions (including a repost/quote menu), removal of the custom modal component, and various style and accessibility improvements throughout the codebase.

UI Feature Additions and Enhancements:

Added a new EmojisView.vue component using the unicode-emoji-picker library to provide a modern emoji picker, and updated dependencies in package.json to include this library. [1] [2]
Enhanced SocialPostActions.vue with a dropdown menu for reposting, removing reposts, and quoting posts, including click-outside detection and improved like/repost logic. [1] [2] [3] [4]

Component and Codebase Cleanup:

Removed the custom BaseModal.vue component, possibly in favor of another modal solution or as part of a cleanup.

Styling and Accessibility Improvements:

Improved image and external content display by adjusting layout classes and fixing word-breaking issues in ImageList.vue, ParsedPost.vue, and ExternalElement.vue. [1] [2] [3] [4] [5] [6]
Minor class and markup simplification for better readability and maintainability, including in ToastNotification.vue.

App Shell and Manifest Changes:

Removed the PWA manifest (manifest.json) and its references from index.html, indicating a move away from PWA features. [1] [2]
Added a permissive robots.txt to allow all crawlers.

Session and Connectivity Handling:

Refactored App.vue to improve session checking, token auto-refresh, and connection status handling, including removal of the inline offline indicator in favor of toast notifications. [1] [2]

Overall, these changes modernize the UI, improve user interactions, and clean up unused or redundant code.

This pull request introduces several UI improvements, dependency updates, and code cleanups. The most significant changes include the addition of an emoji picker component, enhancements to the social post actions (including a repost/quote menu), removal of the custom modal component, and various style and accessibility improvements throughout the codebase. **UI Feature Additions and Enhancements:** * Added a new `EmojisView.vue` component using the `unicode-emoji-picker` library to provide a modern emoji picker, and updated dependencies in `package.json` to include this library. [[1]](diffhunk://#diff-2c66e183577b43f25fa9433d9934668d0e253f9d444a7756b32452f2210d70d5R1-R36) [[2]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R16) * Enhanced `SocialPostActions.vue` with a dropdown menu for reposting, removing reposts, and quoting posts, including click-outside detection and improved like/repost logic. [[1]](diffhunk://#diff-25dad227eef1552f51d9aeced252fe837e689628985fe3db9898a91596433074L4-R5) [[2]](diffhunk://#diff-25dad227eef1552f51d9aeced252fe837e689628985fe3db9898a91596433074L23-R23) [[3]](diffhunk://#diff-25dad227eef1552f51d9aeced252fe837e689628985fe3db9898a91596433074R33-R59) [[4]](diffhunk://#diff-25dad227eef1552f51d9aeced252fe837e689628985fe3db9898a91596433074L64-R184) **Component and Codebase Cleanup:** * Removed the custom `BaseModal.vue` component, possibly in favor of another modal solution or as part of a cleanup. **Styling and Accessibility Improvements:** * Improved image and external content display by adjusting layout classes and fixing word-breaking issues in `ImageList.vue`, `ParsedPost.vue`, and `ExternalElement.vue`. [[1]](diffhunk://#diff-0346174ea21a82597994dd59da2336b4e63c6a0b7d18b86b110273b29b096af0L2-R2) [[2]](diffhunk://#diff-a615f25a35fd1d3c266d5154687995e71eafa64137d1ae64f87d4e5063360f5cL2-R2) [[3]](diffhunk://#diff-76bb609d66325be259b5b7ea08ac31ef4e78db98975aae704fdba0d809a0f6bbL4-R4) [[4]](diffhunk://#diff-76bb609d66325be259b5b7ea08ac31ef4e78db98975aae704fdba0d809a0f6bbL17-R33) [[5]](diffhunk://#diff-76bb609d66325be259b5b7ea08ac31ef4e78db98975aae704fdba0d809a0f6bbL63-R53) [[6]](diffhunk://#diff-76bb609d66325be259b5b7ea08ac31ef4e78db98975aae704fdba0d809a0f6bbL92-R75) * Minor class and markup simplification for better readability and maintainability, including in `ToastNotification.vue`. **App Shell and Manifest Changes:** * Removed the PWA manifest (`manifest.json`) and its references from `index.html`, indicating a move away from PWA features. [[1]](diffhunk://#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051L6-R12) [[2]](diffhunk://#diff-639916bc14c3f311c31f629a2ec116292a4b2f64d06b3607b9ddd2e495703895L1-L32) * Added a permissive `robots.txt` to allow all crawlers. **Session and Connectivity Handling:** * Refactored `App.vue` to improve session checking, token auto-refresh, and connection status handling, including removal of the inline offline indicator in favor of toast notifications. [[1]](diffhunk://#diff-7a7a37b12ee1265d7e27577ec286120d2cbc0940908635e264a2be44ccb9a8a0L3-L13) [[2]](diffhunk://#diff-7a7a37b12ee1265d7e27577ec286120d2cbc0940908635e264a2be44ccb9a8a0L30-R66) Overall, these changes modernize the UI, improve user interactions, and clean up unused or redundant code.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-18 19:07:05 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This pull request introduces extensive UI improvements, dependency updates, and code modernization. The main focus is on adding a comprehensive post creation system with emoji picker support, enhanced social actions for posts (like/repost/quote functionality), and significant PWA configuration improvements.

Added emoji picker component and post creation modal with rich text editing
Enhanced social post actions with dropdown menus for reposting and quoting
Updated PWA configuration with comprehensive caching strategies and manifest improvements

Reviewed Changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
`vite.config.js`	Comprehensive PWA configuration with advanced caching strategies
`src/views/logged/modal/CreatePostView.vue`	New post creation modal with emoji picker and rich text editing
`src/components/EmojisView.vue`	New emoji picker component using unicode-emoji-picker library
`src/components/SocialPostActions.vue`	Enhanced with repost/quote dropdown menu functionality
`src/services/atproto.js`	Added authentication token refresh, logout, and post management APIs
`src/stores/auth.js`	Modernized with automatic token refresh and improved session handling

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This pull request introduces extensive UI improvements, dependency updates, and code modernization. The main focus is on adding a comprehensive post creation system with emoji picker support, enhanced social actions for posts (like/repost/quote functionality), and significant PWA configuration improvements. - Added emoji picker component and post creation modal with rich text editing - Enhanced social post actions with dropdown menus for reposting and quoting - Updated PWA configuration with comprehensive caching strategies and manifest improvements ### Reviewed Changes Copilot reviewed 37 out of 38 changed files in this pull request and generated 11 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | `vite.config.js` | Comprehensive PWA configuration with advanced caching strategies | | `src/views/logged/modal/CreatePostView.vue` | New post creation modal with emoji picker and rich text editing | | `src/components/EmojisView.vue` | New emoji picker component using unicode-emoji-picker library | | `src/components/SocialPostActions.vue` | Enhanced with repost/quote dropdown menu functionality | | `src/services/atproto.js` | Added authentication token refresh, logout, and post management APIs | | `src/stores/auth.js` | Modernized with automatic token refresh and improved session handling | </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/rdenadai/web.redecapivara.social/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

src/App.vue

					
				@ -27,41 +16,54 @@

				</template>

The variable 'intervalId' is not defined in this component. It should be 'autoRefreshTokenIntervalId.value' to match the variable declared on line 33.

  if (autoRefreshTokenIntervalId.value) {
    clearInterval(autoRefreshTokenIntervalId.value)

The variable 'intervalId' is not defined in this component. It should be 'autoRefreshTokenIntervalId.value' to match the variable declared on line 33. ```suggestion if (autoRefreshTokenIntervalId.value) { clearInterval(autoRefreshTokenIntervalId.value) ```

src/components/SocialPostActions.vue

					
				@ -61,52 +76,110 @@

				        />

Error messages are concatenating string with error object. Should use template literals or pass error.message to provide meaningful error information to users.

    toast.error(`Erro ao repostar: ${error && error.message ? error.message : error}`)

Error messages are concatenating string with error object. Should use template literals or pass error.message to provide meaningful error information to users. ```suggestion toast.error(`Erro ao repostar: ${error && error.message ? error.message : error}`) ```

Error messages are concatenating string with error object. Should use template literals or pass error.message to provide meaningful error information to users.

    toast.error(`Erro ao remover repost: ${error.message}`)

Error messages are concatenating string with error object. Should use template literals or pass error.message to provide meaningful error information to users. ```suggestion toast.error(`Erro ao remover repost: ${error.message}`) ```

src/components/SocialPostActions.vue

Error messages are concatenating string with error object. Should use template literals or pass error.message to provide meaningful error information to users.

src/services/atproto.js

					
				@ -33,0 +33,4 @@

				export async function atprotoLogout(serverUrl, accessToken, refreshJwt) {

				  const client = createAuthClient(serverUrl, accessToken)

				  const response = await client.post('/xrpc/com.atproto.server.deleteSession', {

				    headers: { authorization: `Bearer ${refreshJwt}` },

The Authorization header should use capital 'A' for consistency with HTTP standards. Change 'authorization' to 'Authorization'.

    headers: { Authorization: `Bearer ${refreshJwt}` },

The Authorization header should use capital 'A' for consistency with HTTP standards. Change 'authorization' to 'Authorization'. ```suggestion headers: { Authorization: `Bearer ${refreshJwt}` }, ```

src/stores/auth.js

					
				@ -31,35 +31,36 @@ export const useAuthStore = defineStore("auth", () => {

				        did: data.did,

Remove debug console.log statements before production deployment.

Remove debug console.log statements before production deployment. ```suggestion ```

Redundant condition checking 'accessToken.value' twice. The second check should likely be '!refreshToken.value'.

    if (!server.value || !accessToken.value || !refreshToken.value) return

Redundant condition checking 'accessToken.value' twice. The second check should likely be '!refreshToken.value'. ```suggestion if (!server.value || !accessToken.value || !refreshToken.value) return ```

src/stores/auth.js

Remove debug console.log statements before production deployment.

src/views/logged/RedirectPostView.vue

					
				@ -26,10 +26,12 @@

				                  <span class="text-sm text-capivara-stone/60 font-mono">@{{ profileData?.handle }}</span>

Debug template code showing raw post object should be removed before production deployment.

Debug template code showing raw post object should be removed before production deployment. ```suggestion ```

src/views/logged/RedirectPostView.vue

Remove debug console.log statement before production deployment.

Remove debug console.log statement before production deployment. ```suggestion ```

src/views/logged/modal/CreatePostView.vue

					
				@ -0,0 +1,289 @@

				<template>

Remove debug console.log statement before production deployment.

Remove debug console.log statement before production deployment. ```suggestion ```

rdenadai referenced this pull request from a commit

2025-10-30 14:45:00 +00:00

Merge pull request #21 from rdenadai/rdenadai/improvements-add-create-account-others

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

rdenadai/web.redecapivara.social!21

				`@ -31,35 +31,36 @@ export const useAuthStore = defineStore("auth", () => {`
				`did: data.did,`

				`@ -26,10 +26,12 @@`
				`<span class="text-sm text-capivara-stone/60 font-mono">@{{ profileData?.handle }}</span>`

Rows
Columns