Remove SSH connection test from deploy workflow #20

2025-10-18T19:02:35Z

rdenadai commented

2025-10-18 19:02:35 +00:00

(Migrated from github.com)

Removed the SSH connection test step from the deployment workflow.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-18 19:02:50 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR removes the SSH connection test step from the deployment workflow to streamline the deployment process by eliminating a redundant verification step.

Removes the "Test SSH connection" step that was previously used to verify SSH connectivity before deployment

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR removes the SSH connection test step from the deployment workflow to streamline the deployment process by eliminating a redundant verification step. - Removes the "Test SSH connection" step that was previously used to verify SSH connectivity before deployment --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/rdenadai/web.redecapivara.social/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

.github/workflows/deploy.yml

					
				@ -41,10 +41,6 @@ jobs:

				          ssh-keygen -l -f ~/.ssh/id_rsa || { echo "Invalid SSH key"; exit 1; }

				          ssh-keyscan -p ${{ secrets.SSH_PORT }} -H "${{ secrets.VM_IP }}" >> ~/.ssh/known_hosts 2>/dev/null || true

Removing the SSH connection test eliminates early failure detection. If SSH connectivity fails, the deployment will only fail during the rsync step, making it harder to distinguish between SSH connectivity issues and rsync-specific problems. Consider keeping the test or adding error handling to provide clearer failure diagnostics.


      - name: Test SSH connectivity
        run: |
          ssh -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'" || { echo "Error: Unable to connect to VM via SSH"; exit 1; }

Removing the SSH connection test eliminates early failure detection. If SSH connectivity fails, the deployment will only fail during the rsync step, making it harder to distinguish between SSH connectivity issues and rsync-specific problems. Consider keeping the test or adding error handling to provide clearer failure diagnostics. ```suggestion - name: Test SSH connectivity run: | ssh -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'" || { echo "Error: Unable to connect to VM via SSH"; exit 1; } ```

Sign in to join this conversation.

No reviewers