Add SSH connection test step in deploy workflow #14

2025-10-18T17:55:19Z

rdenadai commented

2025-10-18 17:55:19 +00:00

(Migrated from github.com)

Added a step to test the SSH connection before deployment.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-18 17:55:39 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR adds an SSH connection test step to the deployment workflow to verify connectivity before attempting the actual deployment. This helps catch connection issues early and provides better debugging information.

Adds a new "Test SSH connection" step with verbose SSH output for troubleshooting
Places the test step before the actual deployment to validate the connection

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR adds an SSH connection test step to the deployment workflow to verify connectivity before attempting the actual deployment. This helps catch connection issues early and provides better debugging information. - Adds a new "Test SSH connection" step with verbose SSH output for troubleshooting - Places the test step before the actual deployment to validate the connection --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/rdenadai/web.redecapivara.social/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

.github/workflows/deploy.yml

					
				@ -44,1 +44,4 @@

				      - name: Test SSH connection

				        run: |

				          ssh -vvv -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'"

The triple verbose flag (-vvv) produces excessive debug output that may expose sensitive information in CI logs. Consider using single -v for basic connection verification or remove verbose flags entirely for production workflows.

          ssh -v -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'"

The triple verbose flag (-vvv) produces excessive debug output that may expose sensitive information in CI logs. Consider using single -v for basic connection verification or remove verbose flags entirely for production workflows. ```suggestion ssh -v -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'" ```

.github/workflows/deploy.yml

					
				@ -45,3 +48,4 @@

				      - name: Deploy dist/ to VM:/pds

				        run: |

				          rsync -avz --delete -e "ssh -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa -o StrictHostKeyChecking=no" ./dist/ ${{ secrets.VM_USER }}@${{ secrets.VM_IP }}:/pds/web/

Using StrictHostKeyChecking=no bypasses host key verification, making the connection vulnerable to man-in-the-middle attacks. Since ssh-keyscan is used in line 43 to add the host key to known_hosts, this option should be removed to use the proper host verification.

          ssh -vvv -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'"

      - name: Deploy dist/ to VM:/pds
        run: |
          rsync -avz --delete -e "ssh -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa" ./dist/ ${{ secrets.VM_USER }}@${{ secrets.VM_IP }}:/pds/web/

Using StrictHostKeyChecking=no bypasses host key verification, making the connection vulnerable to man-in-the-middle attacks. Since ssh-keyscan is used in line 43 to add the host key to known_hosts, this option should be removed to use the proper host verification. ```suggestion ssh -vvv -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa ${{ secrets.VM_USER }}@${{ secrets.VM_IP }} "echo 'SSH connection successful'" - name: Deploy dist/ to VM:/pds run: | rsync -avz --delete -e "ssh -p ${{ secrets.SSH_PORT }} -i ~/.ssh/id_rsa" ./dist/ ${{ secrets.VM_USER }}@${{ secrets.VM_IP }}:/pds/web/ ```

Sign in to join this conversation.

No reviewers